CookieChangeEvent | add partitioned option & add optional for param & fix event name
#31272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dipikabh
pushed a commit
to dipikabh/content
that referenced
this pull request
Jan 17, 2024
… & fix event name (mdn#31272) * add partitioned key * add Optional_Inline mark * fix event name * add Instance methods section * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
also add the
partitionedoption toCookieChangeEvent.changedandCookieChangeEvent.deleted, which is not added in #23495 and mdn/browser-compat-data#18591fix the event name in
CookieChangeEvent()constructor - should bechangeinstead ofcookiechange, which is related withCookieStore: changeevent; and mark the two params as {{Optional_Inline}}some other small update
see spec https://wicg.github.io/cookie-store/ , also https://developer.mozilla.org/en-US/docs/Web/API/Cookie_Store_API
Motivation
Additional details
Related issues and pull requests